Edit - Stack Overflow

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

Rev

10

This one has a performance issue in cases where the source string is large and there are many occurences of the string to be replaced. string::replace() would be called many times which causes lots of string copies. See my solution which addresses that problem.

Ingmar
– Ingmar

2015-04-21 06:44:38 +00:00
Commented Apr 21, 2015 at 6:44
1

Nit picking ahead: by address => by reference. Whether it's an address or not is an implementation detail.

Max Truxa
– Max Truxa

2015-05-18 16:16:07 +00:00
Commented May 18, 2015 at 16:16
2

You should actually check if from string is empty, otherwise an endless loop will occur.

newbie
– newbie

2015-09-05 02:23:44 +00:00
Commented Sep 5, 2015 at 2:23
This is the most concise and elegant solution. Bolsters my faith in the STL: deceptively simple.

Pierre
– Pierre

2025-02-17 22:01:10 +00:00
Commented Feb 17 at 22:01

Add a comment |

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »

Collectives™ on Stack Overflow