You are not logged in. Your edit will be placed in a queue until it is peer reviewed.
We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.
- 1And you're definitely using threads and not tasks, right?ProgrammingLlama– ProgrammingLlama2019-10-28 00:50:25 +00:00Commented Oct 28, 2019 at 0:50
- In the current codebase yesClinton– Clinton2019-10-28 00:51:03 +00:00Commented Oct 28, 2019 at 0:51
- This test seems like its pointing to bigger problems, this shouldn't really need to be tested for, and if you do, it should probably be covered in another testTheGeneral– TheGeneral2019-10-28 00:55:16 +00:00Commented Oct 28, 2019 at 0:55
- I don't know what you mean, I want to cover this in all tests. It may or may not be a test code that starts the threads, but in either case they should be cleaned up once the test is complete. If they're not this seems like something we should be aware of hence the test should fail.Clinton– Clinton2019-10-28 01:02:53 +00:00Commented Oct 28, 2019 at 1:02
- It would be awesome if you could share a minimal reproducible example.mjwills– mjwills2019-10-28 01:17:13 +00:00Commented Oct 28, 2019 at 1:17
| Show 8 more comments
How to Edit
- Correct minor typos or mistakes
- Clarify meaning without changing it
- Add related resources or links
- Always respect the author’s intent
- Don’t use edits to reply to the author
How to Format
- create code fences with backticks ` or tildes ~ ```
like so
``` - add language identifier to highlight code ```python
def function(foo):
print(foo)
``` - put returns between paragraphs
- for linebreak add 2 spaces at end
- _italic_ or **bold**
- indent code by 4 spaces
- backtick escapes
`like _so_` - quote by placing > at start of line
- to make links (use https whenever possible) <https://example.com>[example](https://example.com)<a href="https://example.com">example</a>
How to Tag
A tag is a keyword or label that categorizes your question with other, similar questions. Choose one or more (up to 5) tags that will help answerers to find and interpret your question.
- complete the sentence: my question is about...
- use tags that describe things or concepts that are essential, not incidental to your question
- favor using existing popular tags
- read the descriptions that appear below the tag
If your question is primarily about a topic for which you can't find a tag:
- combine multiple words into single-words with hyphens (e.g. python-3.x), up to a maximum of 35 characters
- creating new tags is a privilege; if you can't yet create a tag you need, then post this question without it, then ask the community to create it for you
lang-cs