PHP PDO queries not working

Question

I have a dbfunctions class that has the functions to retrieve and write data to database. However, the retrieval doesn't work and I can't understand why it doesn't work.

The read functions looks like this:

public function haeParametreittaTietokannasta($f_sql) { try { $this->sql_lause = $this->db->prepare($f_sql); $this->haku = $this->sql_lause->execute(); } catch (PDOException $ex) { die("Tapahtui virhe tietoja noudettaessa : " . $ex->getMessage()); } if(!$this->haku) { $this->tulos = $this->haku->fetchAll(); return $this->tulos; } else { return false; } } // END FUNCTION

And this is how I call the function:

$countries = $dabase->haeParametreittaTietokannasta("SELECT * FROM countries");

The query always returns false, and I've tried showing error info and it says: array ( 0 => '00000', 1 => NULL, 2 => NULL, ) (And yes, I have created a new object in the main code.)

I've just started to learn PHP and there might be a simple error I just can't see...

What's the $this->sql_lause->execute();

po_taka
– po_taka

2014-07-09 08:24:06 +00:00
Commented Jul 9, 2014 at 8:24 — po_taka
– po_taka, Commented Jul 9, 2014 at 8:24

hjpotter92 · Accepted Answer · 2014-07-09 08:30:01Z

1

You have the wrong if condition:

if(!$this->haku) {

should be

if($this->haku) { $this->tulos = $this->sql_lause->fetchAll();

PDOStatement::execute() returns a boolean value. You can't use it for fetchAll().

edited Jul 9, 2014 at 8:30

answered Jul 9, 2014 at 7:58

hjpotter92

81.1k36 gold badges148 silver badges188 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Avaronald Over a year ago

Didn't help. Now the query throws a fatal error "Fatal error: Call to a member function fetchAll() on a non-object" when trying to fetch results.

hjpotter92 Over a year ago

@Avaronald Do a var_dump($this->haku);

Collectives™ on Stack Overflow

PHP PDO queries not working

1 Answer 1

2 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Related