c++ bad class instance

Question

I have this code and the exercise is to find out which error will occur if I build an Instance of my Class and delete it afterwards. I can't find the fault in the definition of this class so maybe you can help me. Here's the code:

class BadClass{ public: BadClass(){ p = new double; } ~BadClass () {} double getValue() {return *p;} void setValue(double v) {*p = v;} private: double* p; };

See Rule_of_three

Jarod42
– Jarod42

2015-01-04 14:50:15 +00:00
Commented Jan 4, 2015 at 14:50 — Jarod42
– Jarod42, Commented Jan 4, 2015 at 14:50

APerson · Accepted Answer · 2015-01-04 12:50:49Z

2

You call new double in the constructor without a corresponding delete p call in the destructor.

This will result in a memory leak.

answered Jan 4, 2015 at 12:50

APerson

8,4588 gold badges39 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Franklinprogs Over a year ago

Alright thank you @APerson I already thought about this so the standard destructor does not delete dynamic allocated memory?

Erbureth Over a year ago

@Franklinprogs no, you must manage the memory ownership manually in C++. You can however use std::shared_ptr<T> and std::unique_ptr<T> helper classes

Jarod42 Over a year ago

@Erbureth: or even double in this case.

Collectives™ on Stack Overflow

c++ bad class instance

1 Answer 1

3 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Related