How to get position from onCreateViewHolder

Question

I have a RecylerView adapter where I am handling onClicks in the onCreateViewHolder method, however I cannot figure out a way to get the current position. My current method looks like this:

 @Override public ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) { View itemView = LayoutInflater.from(parent.getContext()) .inflate(R.layout.card_small, parent, false); return new ViewHolder(itemView, new ViewHolder.IViewHolderClicks() { @Override public void onImage(ImageView image) { // Need the position for logic in here // for example, myArrayList.get(position); } }); }

Does anybody know how to access the current position from within onCreateViewHolder?

If I stored the position in a class member variable and assigned it in the onBindViewHolder method would that be a reliable method? — nabir
– nabir, Commented Jun 27, 2015 at 20:20

yigit · Accepted Answer · 2015-06-29 06:41:25Z

In your onClick handler, call viewHolder.getAdapterPosition().

@Override public ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) { View itemView = LayoutInflater.from(parent.getContext()) .inflate(R.layout.card_small, parent, false); final ViewHolder vh = ViewHolder(itemView, new ViewHolder.IViewHolderClicks() { @Override public void onImage(ImageView image) { int position = vh.getAdapterPosition(); } }); return vh; }

I've tried that before but I always get the error that the ViewHolder may not have been initialised yet.
can you make IViewHolderClicks() a setter instead of a constructor parameter ?
Sorry I forgot to update! But I made it a setter and it worked fine!

Karakuri · Accepted Answer · 2015-06-27 20:20:31Z

onCreateViewHolder() is not the proper place to store the position. When the ViewHolder gets recycled, you will not get another call to onCreateViewHolder(), so you will not have a chance to "fix" the position when the ViewHolder is recycled.

You can instead do this in onBindViewHolder(), which gives you the position as one of its arguments and is called each time the ViewHolder is recycled.

That's what I was leaning towards, I will try this and see if it works! Cheers!
Don't add listener in onBindViewHolder because that position may change without rebinding the view.

Collectives™ on Stack Overflow

How to get position from onCreateViewHolder

2 Answers 2

4 Comments

2 Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

2 Comments

Related