EF code first - not able to update a database row

Question

Was trying out some code with the EF "code first" method and ran into a strange problem.

My datacontext:

 public class BookmarkerDataContext : DbContext { public DbSet<User> Users { get; set; } protected override void OnModelCreating(System.Data.Entity.ModelConfiguration.ModelBuilder modelBuilder) { modelBuilder.Entity<User>().HasKey(u => u.UserId); base.OnModelCreating(modelBuilder); } }

Where the user object is:

 public class User { public long UserId { get; set; } public ICollection<Tag> Tags { get; set; } }

In my code I am doing something fairly simple:

public void UpdateUserTags(User user,ICollection<Tag> taglist) { user.Tags = new List<Tag>(user.Tags.Union(taglist)); datacontext.Users.Add(user); datacontext.SaveChanges(); }

The user object I am passing to this function is the result of something like:

datacontext.Users.SingleOrDefault(u => u.UserId==id)

Everytime I call the UpdateUserTags function it seems to create a new Row in the User table instead of updating it. Am I doing something wrong here?

RPM1984 · Accepted Answer · 2010-11-03 22:37:26Z

@Donald is correct, you need to Attach to the ObjectContext when making updates.

However, that is only if your entity is detached.

If sounds like you have already retrieved the single entity from the graph:

var user = datacontext.Users.SingleOrDefault(u => u.UserId==id);

Which means you don't need to Attach or get it again. Just do this:

var user = datacontext.Users.SingleOrDefault(u => u.UserId==id); user.Tags = new List<Tag>(user.Tags.Union(taglist)); context.SaveChanges();

However, i wouldn't recommend replacing the entire Tags collection, add the tags:

user.Tags.Add(someTag);

HTH

Donald · Accepted Answer · 2010-11-03 21:57:35Z

I believe you want to Attach your object to the data context, instead of Adding it.

public void UpdateUserTags(User user,ICollection<Tag> taglist) { datacontext.Attach(user); user.Tags = new List<Tag>(user.Tags.Union(taglist)); datacontext.SaveChanges(); }

Once it is attached, then the context becomes aware of the object. Once you save changes, they should be persisted to the database.

DarinH · Accepted Answer · 2010-11-03 21:57:13Z

Won't this line

datacontext.Users.Add(user);

Always mark the user record as needing to be ADDED to the users table.

I think you have to DETACH the user from the old context and ATTACH it to the new to properly be able to update the record. but I'm no EF wonk so ymmv

PsychoCoder · Accepted Answer · 2010-11-03 22:13:16Z

This has nothing to do with your particular issue but for lazy loading you're going to want Tags to be marked virtual

public virtual ICollection<Tag> Tags { get; set; }

Also, it looks like you're trying to add new tags for a user (or update their tags) if that is the case then you're going to want to use Attach as Donald suggested

virtual has nothing to do with lazy loading. virtual has to do with when you want change tracking (EF will create a proxy class, overriding all members).
You're right that's my bad, been a long day. Thanks for pointing out my mistake ;)

Collectives™ on Stack Overflow

EF code first - not able to update a database row

4 Answers 4

Comments

Comments

Comments

2 Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

2 Comments

Related