Getting Filename from url in C#

Question

Currently we have a solution that grabs the filename from the URL using this

currentFile = Path.GetFileNameWithoutExtension(url);

We found that if there are query strings attached that include characters such as quotes it returns with an error of Illegal characters in path.

For example if the url is

http:\\myurl.com\mypage.aspx?utm_content=This+Is+"Broken"

Then it won't get the filename. Is there a better, cleaner way to get "mypage"?

Can't you just remove the query string from the url before calling GetFileNameWithoutExtension? — G_P
– G_P, Commented Dec 14, 2011 at 20:39
check this one: stackoverflow.com/a/6015377/559144 and vote him up if it solves your issue ;-) — Davide Piras
– Davide Piras, Commented Dec 14, 2011 at 20:39
did you try Server.UrlEncode(url); before getting the file name ? — A.B.Cade
– A.B.Cade, Commented Dec 14, 2011 at 20:41
Please consider that URLs need not refer to files, and that names with no illegal characters can still be illegal filenames. — Dour High Arch
– Dour High Arch, Commented Dec 14, 2011 at 20:51

Davide Piras · Accepted Answer · 2011-12-14 20:41:26Z

22

use this: Uri.AbsolutePath

Request.Url.AbsolutePath

answered Dec 14, 2011 at 20:41

Davide Piras

44.7k10 gold badges103 silver badges150 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

jocull Over a year ago

string filename = Path.GetFileName(new Uri(myUrlString).AbsolutePath);

competent_tech · Accepted Answer · 2011-12-14 20:39:34Z

3

I would just find the ? and if it exists, strip the rest of the string, then use that to GetFileNameWithoutExtension.

For example:

 string url; int index; index = url.IndexOf("?"); if (index != -1) { url = url.Substring(0, index); } currentFile = Path.GetFileNameWithoutExtension(url);

answered Dec 14, 2011 at 20:39

competent_tech

45.1k12 gold badges96 silver badges114 bronze badges

2 Comments

Davide Piras Over a year ago

this is way more complicated and verbose than what the framework already offers: Request.Url.AbsolutePath

competent_tech Over a year ago

@DavidePiras: Why are you assuming that the URL being processed is the request url? The OP made no mention of this in the initial question. The solution I provided was a direct response to their posted code which only referenced a URL. This url could be from a log file, it could be from a referral string, or from a parsed HTML page with embedded references.

Marvin Smit · Accepted Answer · 2011-12-14 20:41:14Z

use HttpContext.Current.Request.PhysicalPath instead of the full URL as parameter into the Path.GetFileNameWithoutExtension method.

Hope this helps,

Collectives™ on Stack Overflow

Getting Filename from url in C#

3 Answers 3

1 Comment

2 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

Comments

Linked

Related