Bug: Fixing a topic Damages the Meta Fileattachment

The %META:FILEATTACHMENT{}% can get damaged when fixing a topic with the undocumented command. It happens for attachments that contain double quotes in the comment field.

Test case

• Create a topic and attach a file to it with the comment: "How to" instructions
• Wait for one hour to get a new revision (or log in as a different user)
• Edit the topic and "fix" something using the undocumented command.
• Preview and save
• Look at the diff
  • Before: %META:FILEATTACHMENT{name="test.html" attr="" comment="%_Q_%How to%_Q_% instructions" date="999725940" path="test.html" size="14421" user="pad" version=""}%
  • After: %META:FILEATTACHMENT{name="test.html" How to" instructions" date="999725940" attr="" comment="" path="test.html" size="14421" user="pad" version=""}%

Fix record

This is caused because %_Q_% is used for moving text between between into preview and is also used within meta data. Other special characters are also affected.

Would around:

• remove quotes using undocumented command.
• Put them back by selecting attachments, changing comment and using change properties

Fix:

• In preview convert %_(.)_% to %__$1__%
• In save convert back.

I'd be grateful if people could check this out and do some more testing.

Fix uploaded to cvs.

-- JohnTalintyre - 04 Oct 2001

Environment

-- PeterThoeny - 03 Oct 2001