Bug: Problem on Windows see old binary attachments

Need to switch to binmode when getting output from RCS co command, but can't do that (at least I don't know how) when using backticks to run the command.

Test case

Attachment a word doc, change it and attach again, you're likely to just see junk.

Environment

TWiki version: Alpha (and probably all older one with attachments under rev control
TWiki plugins: -
Server OS: Windows
Web server: -
Perl version: -
Client OS: -
Web Browser: -

-- JohnTalintyre - 27 Mar 2002

Follow up

Fix record

For Windows put output in a temporary file, read in binmode and delete temporary file. Implemented in Store/RcsWrap.pm and Store/RcsFile.pm. Note this has brought in usage of File::Spec - I don't know how standard this is.

-- JohnTalintyre - 27 Mar 2002

More binmode craziness smile ... File::Spec is standard in Perl 5.005_03 - there's a link to the list of built-in modules at ReadmeFirst.

BTW, what happens to topics marked TWikiAlphaRelease when it becomes BeijingRelease? Does someone do a mass update?

It would be good if there was a TWikiAlphaReleaseBeijing or something, so that older topics can easily be seen as 'alpha leading to Beijing' rather than 'some alpha, not clear which one'... +1 -- RandyKramer - 28 Mar 2002

-- RichardDonkin - 28 Mar 2002

Edit | Attach | Watch | Print version | History: r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r3 - 2002-03-28 - RandyKramer
 
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2026 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.