Skip to main content
added comment on bitwise operators.
Source Link
AJD
  • 205
  • 1
  • 4
  • 8

Check your spelling Intensity instead of Intesity.

Consider using switch instead of if-then-else.

Define left, right and middle as [integer] constants somewhere (and probably something more descriptive like rightLED, leftLED and middleLED) because your code is looking for an int, instead you give it something undefined like left, right and middle (and all). I would consider using bitwise operators for identifying the LEDS, instead of a simple integer flag as this gives future flexibility in lighting up combinations without changing your code (the current function would be rewritten to accommodate this).

Check your spelling Intensity instead of Intesity.

Consider using switch instead of if-then-else.

Define left, right and middle as [integer] constants somewhere (and probably something more descriptive like rightLED, leftLED and middleLED) because your code is looking for an int, instead you give it something undefined like left, right and middle (and all).

Check your spelling Intensity instead of Intesity.

Consider using switch instead of if-then-else.

Define left, right and middle as [integer] constants somewhere (and probably something more descriptive like rightLED, leftLED and middleLED) because your code is looking for an int, instead you give it something undefined like left, right and middle (and all). I would consider using bitwise operators for identifying the LEDS, instead of a simple integer flag as this gives future flexibility in lighting up combinations without changing your code (the current function would be rewritten to accommodate this).

Source Link
AJD
  • 205
  • 1
  • 4
  • 8

Check your spelling Intensity instead of Intesity.

Consider using switch instead of if-then-else.

Define left, right and middle as [integer] constants somewhere (and probably something more descriptive like rightLED, leftLED and middleLED) because your code is looking for an int, instead you give it something undefined like left, right and middle (and all).