Return to Answer

deleted 20 characters in body

Source Link

edited May 9, 2019 at 18:35

AnT stands with Russia

Equality comparison in C and C++ is expressed by == operator. ==, not =. This
```
 if (wavecolor = 0) { 
```

actually assigns zero to your wavecolor variable, thus destroying the value you just read.

The common sense says that you actually need and in your conditions, not or
```
 if (wavecolor > 0 and wavecolor < 333) { 
```

The or conditions that you curently use are simply always true, which makes them nonsensical.

This is valid syntax

 if (wavecolor > 0 or wavecolor < 333) if (wavecolor > 0 and wavecolor < 333)

but you might want to try using more "canonical" forms

 if (wavecolor > 0 || wavecolor < 333) if (wavecolor > 0 && wavecolor < 333)

or and and are "alternative" forms of || and && operators, introduced a long time ago for reasons that are all but obsolete today.

Assuming that you meant and instead of or, in your conditions you managed to "exclude" such values as 333, 667 and 1022 - they wouldn't match any of and conditions. Changing some strict comparisons to non-strict ones might be in order.
As a side note, in a single-file program all file-scope variables should be either const or static. In your case
```
 const int redpin = 6; const int greenpin = 3; const int bluepin = 5; const int potPin = 0; 
```

Equality comparison in C and C++ is expressed by == operator. ==, not =. This
```
 if (wavecolor = 0) { 
```

actually assigns zero to your wavecolor variable, thus destroying the value you just read.

The common sense says that you actually need and in your conditions, not or
```
 if (wavecolor > 0 and wavecolor < 333) { 
```

The or conditions that you curently use are simply always true, which makes them nonsensical.

This is valid syntax

 if (wavecolor > 0 or wavecolor < 333) if (wavecolor > 0 and wavecolor < 333)

but you might want to try using more "canonical" forms

 if (wavecolor > 0 || wavecolor < 333) if (wavecolor > 0 && wavecolor < 333)

or and and are "alternative" forms of || and && operators, introduced a long time ago for reasons that are all but obsolete today.

Assuming that you meant and instead of or, in your conditions you managed to "exclude" such values as 333, 667 and 1022 - they wouldn't match any of and conditions. Changing some strict comparisons to non-strict ones might be in order.
As a side note, in a single-file program all file-scope variables should be either const or static. In your case
```
 const int redpin = 6; const int greenpin = 3; const int bluepin = 5; const int potPin = 0; 
```

Equality comparison in C and C++ is expressed by == operator. ==, not =. This
```
 if (wavecolor = 0) { 
```

actually assigns zero to your wavecolor variable, thus destroying the value you just read.

The common sense says that you actually need and in your conditions, not or
```
 if (wavecolor > 0 and wavecolor < 333) { 
```

The or conditions that you curently use are simply always true, which makes them nonsensical.

This is valid syntax

 wavecolor > 0 or wavecolor < 333 wavecolor > 0 and wavecolor < 333

but you might want to try using more "canonical" forms

 wavecolor > 0 || wavecolor < 333 wavecolor > 0 && wavecolor < 333

or and and are "alternative" forms of || and && operators, introduced a long time ago for reasons that are all but obsolete today.

Assuming that you meant and instead of or, in your conditions you managed to "exclude" such values as 333, 667 and 1022 - they wouldn't match any of and conditions. Changing some strict comparisons to non-strict ones might be in order.
As a side note, in a single-file program all file-scope variables should be either const or static. In your case
```
 const int redpin = 6; const int greenpin = 3; const int bluepin = 5; const int potPin = 0; 
```

deleted 1 character in body

Source Link

edited May 9, 2019 at 18:27

AnT stands with Russia

Equality comparison in C and C++ is expressed by == operator. ==, not =. This
```
 if (wavecolor = 0) { 
```

actually assigns zero to your wavecolor variable, thus destroying the value you just read.

The common sense says that you actually need and in your conditions, not or
```
 if (wavecolor > 0 and wavecolor < 333) { 
```

The or conditions that you curently use are simply always truealways true, which makes them nonsensical.

This is valid syntax

 if (wavecolor > 0 or wavecolor < 333) if (wavecolor > 0 and wavecolor < 333)

but you might want to try using a more "canonical" formforms

 if (wavecolor > 0 || wavecolor < 333) if (wavecolor > 0 && wavecolor < 333)

or and and are "alternative" forms of || and && operators, introduced a long time ago for reasons that are all but obsolete today.

Assuming that you meant and instead of or, in your conditions you managed to "exclude" such values as 333, 667 and 1022 - they don'twouldn't match any of yourand conditions. Changing some strict comparisons to non-strict ones might be in order.
As a side note, in a single-file program all file-scope variables should be either const or static. In your case
```
 const int redpin = 6; const int greenpin = 3; const int bluepin = 5; const int potPin = 0; 
```

Equality comparison in C and C++ is expressed by == operator. ==, not =. This
```
 if (wavecolor = 0) { 
```

actually assigns zero to your wavecolor variable, thus destroying the value you just read.

The common sense says that you actually need and in your conditions, not or
```
 if (wavecolor > 0 and wavecolor < 333) { 
```

The or conditions that you curently use are simply always true, which makes them nonsensical.

This is valid syntax

 if (wavecolor > 0 or wavecolor < 333) if (wavecolor > 0 and wavecolor < 333)

but you might want to try using a more "canonical" form

 if (wavecolor > 0 || wavecolor < 333) if (wavecolor > 0 && wavecolor < 333)

or and and are "alternative" forms of || and && operators, introduced a long time ago for reasons that are obsolete today.

Assuming that you meant and instead of or, in your conditions you managed to "exclude" such values as 333, 667 and 1022 - they don't match any of your conditions.
As a side note, in a single-file program all file-scope variables should be either const or static. In your case
```
 const int redpin = 6; const int greenpin = 3; const int bluepin = 5; const int potPin = 0; 
```

Equality comparison in C and C++ is expressed by == operator. ==, not =. This
```
 if (wavecolor = 0) { 
```

actually assigns zero to your wavecolor variable, thus destroying the value you just read.

The common sense says that you actually need and in your conditions, not or
```
 if (wavecolor > 0 and wavecolor < 333) { 
```

The or conditions that you curently use are simply always true, which makes them nonsensical.

This is valid syntax

 if (wavecolor > 0 or wavecolor < 333) if (wavecolor > 0 and wavecolor < 333)

but you might want to try using more "canonical" forms

 if (wavecolor > 0 || wavecolor < 333) if (wavecolor > 0 && wavecolor < 333)

or and and are "alternative" forms of || and && operators, introduced a long time ago for reasons that are all but obsolete today.

Assuming that you meant and instead of or, in your conditions you managed to "exclude" such values as 333, 667 and 1022 - they wouldn't match any of and conditions. Changing some strict comparisons to non-strict ones might be in order.
As a side note, in a single-file program all file-scope variables should be either const or static. In your case
```
 const int redpin = 6; const int greenpin = 3; const int bluepin = 5; const int potPin = 0; 
```

added 67 characters in body

Source Link

edited May 9, 2019 at 18:24

AnT stands with Russia

Equality comparison in C and C++ is expressed by == operator. ==, not =. This
```
 if (wavecolor = 0) { 
```

actually assigns zero to your wavecolor variable, thus destroying the value you just read.

The common sense says that you actually need and in your conditions, not or
```
 if (wavecolor > 0 and wavecolor < 333) { 
```

The or conditions that you curently use are simply always true, which makes them nonsensical.

This is valid syntax

 if (wavecolor > 0 or wavecolor < 333) if (wavecolor > 0 and wavecolor < 333)

but you might want to try using a more "canonical" form

 if (wavecolor > 0 || wavecolor < 333) if (wavecolor > 0 && wavecolor < 333)

or is anand and are "alternative" formforms of || operatorand && operators, introduced a long time ago for reasons that are obsolete today.

However, the common sense says that you actually need && here, which is and, not or.

InAssuming that you meant and instead of or, in your conditions you managed to "exclude" such values as 333, 667 and 1022 - they don't match any of your conditions.
As a side note, in a single-file program all file-scope variables should be either const or static. In your case
```
 const int redpin = 6; const int greenpin = 3; const int bluepin = 5; const int potPin = 0; 
```

Equality comparison in C and C++ is expressed by == operator. ==, not =. This
```
 if (wavecolor = 0) { 
```

actually assigns zero to your wavecolor variable, thus destroying the value you just read.

This is valid
```
 if (wavecolor > 0 or wavecolor < 333) 
```

but you might want to try using a more "canonical" form

 if (wavecolor > 0 || wavecolor < 333)

or is an "alternative" form of || operator, introduced a long time ago for reasons that are obsolete today.

However, the common sense says that you actually need && here, which is and, not or.

In your conditions you managed to "exclude" such values as 333, 667 and 1022 - they don't match any of your conditions.
As a side note, in a single-file program all file-scope variables should be either const or static. In your case
```
 const int redpin = 6; const int greenpin = 3; const int bluepin = 5; const int potPin = 0; 
```

Equality comparison in C and C++ is expressed by == operator. ==, not =. This
```
 if (wavecolor = 0) { 
```

actually assigns zero to your wavecolor variable, thus destroying the value you just read.

The common sense says that you actually need and in your conditions, not or
```
 if (wavecolor > 0 and wavecolor < 333) { 
```

The or conditions that you curently use are simply always true, which makes them nonsensical.

This is valid syntax

 if (wavecolor > 0 or wavecolor < 333) if (wavecolor > 0 and wavecolor < 333)

but you might want to try using a more "canonical" form

 if (wavecolor > 0 || wavecolor < 333) if (wavecolor > 0 && wavecolor < 333)

or and and are "alternative" forms of || and && operators, introduced a long time ago for reasons that are obsolete today.

Assuming that you meant and instead of or, in your conditions you managed to "exclude" such values as 333, 667 and 1022 - they don't match any of your conditions.
As a side note, in a single-file program all file-scope variables should be either const or static. In your case
```
 const int redpin = 6; const int greenpin = 3; const int bluepin = 5; const int potPin = 0; 
```

added 67 characters in body

Source Link

edited May 9, 2019 at 18:18

AnT stands with Russia

Source Link

answered May 9, 2019 at 18:12

AnT stands with Russia