Timeline for Executing a stored procedure with optional attributes
Current License: CC BY-SA 3.0
8 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Dec 10, 2015 at 16:46 | comment | added | Dib | So I may have to revert back the code back again then tonight! | |
| Dec 10, 2015 at 14:27 | comment | added | svick | These interfaces are considered deprecated since .Net 2.0 and aren't currently available on .Net Core. So it may not be a good idea to use them. | |
| Dec 10, 2015 at 10:04 | comment | added | RubberDuck | Awesome @Dib, but please don't update your post. We have a policy of asking new questions for iterative reviews. Happy to help, it really was a pleasure to read this code. | |
| Dec 10, 2015 at 7:06 | vote | accept | Dib | ||
| Dec 10, 2015 at 7:06 | comment | added | Dib | I have been able to swap out the concrete DbConnection to be the IDbConnection interface, and this has also driven out other code that this object depends upon to swap out usage of the concrete DbCommand to the IDbCommand interface and also DbDataReader to IDataReader, which is a good thing. All of my existing tests pass so nothing is broken from those changes, and I now have better options to create further tests. I'll update my post to include your suggested change. | |
| Dec 10, 2015 at 6:50 | comment | added | Dib | I'll feed back after investigation into using the interface. Thanks again for the constructive review. | |
| Dec 10, 2015 at 6:45 | comment | added | Dib | Thank you for the constructive review. I will certainly look at using the IDbConnection as I don't think there is anything I need that is not in the interface. It may however have a knock on effect on some of the objects this class uses. I will investigate and see. The deeper unit testing benefit will be a big plus! I'm not using C#6, but will investigate if there are other benefits. I can see your point on not caching the ResultType, as there is no runtime performance loss, due to the typing being done at compile time, The only benefit is mildly cleaner code, so I may leave that in. | |
| Dec 10, 2015 at 0:51 | history | answered | RubberDuck | CC BY-SA 3.0 |