Skip to main content
8 events
when toggle format what by license comment
Nov 16, 2016 at 14:17 comment added ferada Yes indeed, but this should get you thinking about how to restructure it, maybe put the parameters in a list and call the method in a loop with each of them, or something else ... usually data-driven is more flexible and a bit shorter than hard coding the function calls.
Nov 16, 2016 at 14:01 comment added Marius just what i needed, thank's for clearing up the last points! This has been really helpful for me! Last thing, i would still need to call all my functions like i do now right? I mean the full list i have at the start of my main().
Nov 16, 2016 at 13:58 vote accept Marius
Nov 16, 2016 at 13:45 comment added ferada Added some more code, hope that helps.
Nov 16, 2016 at 13:44 history edited ferada CC BY-SA 3.0
added 478 characters in body
Nov 16, 2016 at 10:36 comment added Marius Okay, so i managed to figure it all out, except 2 things, I did not manage to simplify get_alienvault.. I did not manage to simplify the write operations to file (though i did add while and removed f.close() Would you be able to describe these two procedures? I also tried to simplify the domain lists, but that was impossible, as they all have different filtering.
Nov 16, 2016 at 7:57 comment added Marius Il keep this short, since i dont have a lot of characters. 1. Was not really needed to be a class, it just started out that way, if there is no need for it, il remove it and save a few lines. 2. Which temp variables? And do you mean comments? 3. Okay il move up the urls, and rename them for each feed. 4. I guess d is not an issue anymore, as i move away from class. 5. I will try to see what i can do about getting it smaller, but that's why i came here. 6. Can i run all the functions in one loop? 7. I will remove the returns. 8. Okay, i change up the get_alienvault as well, to test
Nov 15, 2016 at 21:05 history answered ferada CC BY-SA 3.0