Timeline for Calculate Final Grade: follow-up
Current License: CC BY-SA 4.0
10 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Mar 19, 2019 at 8:27 | comment | added | janos | @Mori The comment helps, but it's better to describe things with code when easily possible. Comments can become out of date with the code they refer to. Code on the other hand never lies. | |
| Mar 19, 2019 at 7:08 | comment | added | Mori | " no clue to the reader what they represent, and why they are those particular values" Doesn't the JavaScript comment help? | |
| Mar 19, 2019 at 6:29 | comment | added | janos | @Mori I reviewed your revised code now (sorry I was busy / forgetful). It looks much better. The only missing is the weights per grade are still magic numbers 3 and 2. They are called "magic" because they have no name, and so no clue to the reader what they represent, and why they are those particular values. To make them less magical, give them descriptive names. For example physicsWeight and historyWeight. | |
| Mar 19, 2019 at 6:27 | comment | added | janos | @Mori Why did you award the bounty to this answer? I was certain you would award it to other answers with more concrete detail. If this happened by mistake, the moderators might be able to fix it. | |
| Mar 19, 2019 at 4:51 | history | bounty awarded | Mori | ||
| Mar 19, 2019 at 4:51 | vote | accept | Mori | ||
| Mar 31, 2019 at 12:38 | |||||
| Mar 12, 2019 at 16:06 | comment | added | Mori | Good point, but I've already offered a bounty for this question and don't want to take the reviewers to a new one. | |
| Mar 12, 2019 at 15:57 | comment | added | janos | @Mori if you would like a review of your updated implementation, it's good to ask it as a new question. See the conversations here for example | |
| Mar 12, 2019 at 15:30 | comment | added | Mori | Thanks for the review! I just added an update according to your hints. Is it better now? | |
| Mar 9, 2019 at 18:30 | history | answered | janos | CC BY-SA 4.0 |