Revisions to Vector (physics) implementation

Tweeted twitter.com/#!/StackCodeReview/status/527186591987421184

occurred Oct 28, 2014 at 19:54

Rollback to Revision 4

edited Oct 28, 2014 at 8:06

25.5k
7
59
141

Here's my re-factored code, based on input from as many answers as possible. Thanks for the feedback!

import java.util.*; class Vector { private final double x; private final double y; public Vector(double x, double y) { this.x = x; this.y = y; } public Vector add(Vector other) { return new Vector(x + other.x, y + other.y); } public Vector sub(Vector other) { return new Vector(x - other.x, y - other.y); } public double scalar(Vector other) { return x * other.x + y * other.y; } public double lengthSq() { return x * x + y * y; } public double length() { return Math.sqrt(lengthSq()); } public double distSq(Vector other) { double dx = x - other.x; double dy = y - other.y; return dx * dx + dy * dy; } public double distance(Vector other) { return Math.sqrt(distSq(other)); } }

Here's my re-factored code, based on input from as many answers as possible. Thanks for the feedback!

import java.util.*; class Vector { private final double x; private final double y; public Vector(double x, double y) { this.x = x; this.y = y; } public Vector add(Vector other) { return new Vector(x + other.x, y + other.y); } public Vector sub(Vector other) { return new Vector(x - other.x, y - other.y); } public double scalar(Vector other) { return x * other.x + y * other.y; } public double lengthSq() { return x * x + y * y; } public double length() { return Math.sqrt(lengthSq()); } public double distSq(Vector other) { double dx = x - other.x; double dy = y - other.y; return dx * dx + dy * dy; } public double distance(Vector other) { return Math.sqrt(distSq(other)); } }

added 12 characters in body

Source Link

edited Oct 27, 2014 at 23:39

Ethan Bierlein

15.9k
4
60
146

import java.util.*; class Vector { private final double x; private final double y; public Vector(double x, double y) { this.x = x; this.y = y; } public Vector add(Vector other) { return new Vector(x + other.x, y + other.y); } public Vector sub(Vector other) { return new Vector(x - other.x, y - other.y); } public double scalar(Vector other) { return x * other.x + y * other.y; } public double lengthSq() { return x*x+y*y;x * x + y * y; } public double length() { return Math.sqrt(lengthSq()); } public double distSq(Vector other) { double dx = x - other.x; double dy = y - other.y; return dx*dx+dy*dy;dx * dx + dy * dy; } public double distance(Vector other) { return Math.sqrt(distSq(other)); } }

import java.util.*; class Vector { private final double x; private final double y; public Vector(double x, double y) { this.x = x; this.y = y; } public Vector add(Vector other) { return new Vector(x + other.x, y + other.y); } public Vector sub(Vector other) { return new Vector(x - other.x, y - other.y); } public double scalar(Vector other) { return x * other.x + y * other.y; } public double lengthSq() { return x*x+y*y; } public double length() { return Math.sqrt(lengthSq()); } public double distSq(Vector other) { double dx = x - other.x; double dy = y - other.y; return dx*dx+dy*dy; } public double distance(Vector other) { return Math.sqrt(distSq(other)); } }

import java.util.*; class Vector { private final double x; private final double y; public Vector(double x, double y) { this.x = x; this.y = y; } public Vector add(Vector other) { return new Vector(x + other.x, y + other.y); } public Vector sub(Vector other) { return new Vector(x - other.x, y - other.y); } public double scalar(Vector other) { return x * other.x + y * other.y; } public double lengthSq() { return x * x + y * y; } public double length() { return Math.sqrt(lengthSq()); } public double distSq(Vector other) { double dx = x - other.x; double dy = y - other.y; return dx * dx + dy * dy; } public double distance(Vector other) { return Math.sqrt(distSq(other)); } }

added 1143 characters in body

Source Link

edited Oct 27, 2014 at 22:56

Ethan Bierlein

15.9k
4
60
146

Here's my re-factored code, based on input from as many answers as possible. Thanks for the feedback!

import java.util.*; class Vector { private final double x; private final double y; public Vector(double x, double y) { this.x = x; this.y = y; } public Vector add(Vector other) { return new Vector(x + other.x, y + other.y); } public Vector sub(Vector other) { return new Vector(x - other.x, y - other.y); } public double scalar(Vector other) { return x * other.x + y * other.y; } public double lengthSq() { return x*x+y*y; } public double length() { return Math.sqrt(lengthSq()); } public double distSq(Vector other) { double dx = x - other.x; double dy = y - other.y; return dx*dx+dy*dy; } public double distance(Vector other) { return Math.sqrt(distSq(other)); } }

Here's my re-factored code, based on input from as many answers as possible. Thanks for the feedback!

import java.util.*; class Vector { private final double x; private final double y; public Vector(double x, double y) { this.x = x; this.y = y; } public Vector add(Vector other) { return new Vector(x + other.x, y + other.y); } public Vector sub(Vector other) { return new Vector(x - other.x, y - other.y); } public double scalar(Vector other) { return x * other.x + y * other.y; } public double lengthSq() { return x*x+y*y; } public double length() { return Math.sqrt(lengthSq()); } public double distSq(Vector other) { double dx = x - other.x; double dy = y - other.y; return dx*dx+dy*dy; } public double distance(Vector other) { return Math.sqrt(distSq(other)); } }