Timeline for What is considered a production ready ERC20 token smart contract
Current License: CC BY-SA 3.0
7 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jan 28, 2018 at 21:16 | comment | added | wuno | I would really like to perfect this contract. I am little confused why you think converting msg.valu to wei could be a problem. Would you mind explaining that a little more to me? Also when you mention overflows you mean a stack overflow? Like if the values add up to be more than uint256? | |
| Jan 23, 2018 at 11:58 | comment | added | Shomari | what happened? did the tx fail? uint256 amount = msg.value * unitsOneEthCanBuy; might be a problem, since msg.value is in wei not ether. Also, consider adding SafeMath to protect from overflows. | |
| Jan 22, 2018 at 23:54 | comment | added | wuno | Right on thanks man. One more thing, I actually tested my contract last night. I expected it to automatically send 1000 of my token to the address of the person who sends 1ETH into the contract. But that does not happen. It did for sure create the tokens and place them in the address I submitted the contract into the blockchain from. What am I missing here for it to work the way that I was expecting? For the money to be a transaction. Send in 1 ether and get back the 1000 coins. | |
| Jan 22, 2018 at 14:06 | comment | added | Shomari | I would only expect the contract owners to actually use the burn function, maybe to destroy whatever is not sold during the ICO, as you pointed out, anyone else who uses it would be destroying their tokens (I can't think of a good reason to do that). | |
| Jan 21, 2018 at 21:46 | vote | accept | wuno | ||
| Jan 21, 2018 at 21:46 | comment | added | wuno | Thanks for your input on this. Your logic totally makes sense but I can not understand why TRX would be coming into the contract, let alone in to be burned. Would this not only be for people to buy TRX specifically during an ICO and then whatever is left? In that case it would only be going out so how would it be burning coins? But thanks for answering the original question. | |
| Jan 21, 2018 at 20:54 | history | answered | Shomari | CC BY-SA 3.0 |