Re-Implement DeLight simulations in C++ source#4459
Conversation
… 78282198-DeLightTranslation
…gainst it, though the current E+ DeLight source doesnt make any calls to the library yet. [#78282198]
… know. [#78282198]
| Holy cow! This actually runs, and puts out numbers, the eplusout.delight* are created, this may actually be done once the ExternalInterface changes are done. |
At this point, I am getting tiny tiny diffs in the 3 DElight test files I am using...I think DElight is done. [#78282198]
| OK, with the last commit in place (bdd21dc) I am getting tiny tiny diffs in the 3 DElight files I am testing with. Things look very very good. I will test it again once the ExternalInterface work gets in, but as far as I am concerned this is done and ready to merge. Just FYI @mjwitte @vidanovic @hongtz68 |
| @Myoldmopar it has been 7 days since this pull request was last updated. |
…ting with both in place [#78282198]
| @Myoldmopar it has been 7 days since this pull request was last updated. |
…ce' into 78282198-DeLightTranslation
| @kbenne This could potentially be ready to merge. I've address the compiler warnings that the CI and I were seeing, and merged in the latest state of the 74724778-ExternalInterface branch. If this comes back clean on CI, it should be able to drop once the external interface branch drops. |
| @Myoldmopar @lgentile it has been 7 days since this pull request was last updated. |
| OK, pulled this down and re-built...again. Comparing to the 8.1 release (since develop doesn't have DeLight) reveals a successful build and just tiny diffs still. This is on Linux. I'll try on Windows over the weekend or Monday and if it works, I'm inclined to merge this in. Just a heads up @kbenne @mjwitte. |
| I'll look into it shortly. |
@Myoldmopar the linker error was coming from EnergyPlus_tests, not EnergyPlus.exe
| Thanks @lefticus, glad it is building, and everything in the world now makes sense 😄. I merged develop into this branch to see if the version errors go away or if they stay. Anyway, this is now merge-able from the source code standpoint. @kbenne I'm having a little trouble keeping the version stuff straight. Are these warnings expected? Are the IDFs and the DataStringGlobals configuration synced up so that they shouldn't warn? |
| @Myoldmopar Made a win64 debug build of this and ran three DElight example files and compare results to 8.1. All OK. Merging. |
| Thanks @mjwitte! DElight is finally back in! |
Myoldmopar changed the title | Fixed #4504 |
4 participants
DeLight implementation
NOTE
This branch is based on the External Interface branch, so that branch needs to be merged in first once it is complete.