Cleanup IDD issues with object-list and reference tags#4597
Cleanup IDD issues with object-list and reference tags#4597
Conversation
This reverts commit bd7147b.
…Plus into 4525-Object-list_Referencing
| @Myoldmopar @mmAtTs After the errors are fixed, I still need to do another review. Been busy with other tasks this week. |
| @Myoldmopar @mjwitte There was one error that I introduced in the |
| @Myoldmopar CI is showing what looks to me to be minor diffs in the eio files for |
| As far as I can tell, they are absolute random diffs from the DeLight library. Presumably there is something uninitialized or random going on over there, but we haven't yet nailed it down. @EnergyArchmage mentioned that seeing random diffs with DeLight was nothing new, so we're just moving forward, hopeful to figure out the problem sometime soon. So, don't worry about it, it's nothing your branch did. |
| @mmAtTs @Myoldmopar Fixed a couple of errors, quibbled Non-Dimensional back to Nondimensional, and some other cleanup. Please review to see if you agree. @mmAtTs This turned out to be much large than anticipated - thanks for sticking with this. |
| Fixes #4525 |
… MJW change from part of #4597) SurfaceNames are only base surfaces
Myoldmopar changed the title 5 participants
@mmAtTs If you check out the test failures at the (currently) bottom of this pull request, you'll see there are some error messages coming out. If you could address those, it would be nice to get this in.