Fix crash when duplicate node names are used in zone connections object#4640
Conversation
…ject. Github issue $4577, Pivotal #84202670
| @JasonGlazer @lgentile it has been 7 days since this pull request was last updated. |
1 similar comment
| @JasonGlazer @lgentile it has been 7 days since this pull request was last updated. |
| @mjwitte Added a unit test. |
| @JasonGlazer This is a good fix, and the unit test looks great. I made a commit just to clean up a whitespace change, and I'll let CI make a pass through then merge it in. |
[#84202670]
| These CI tests that have failed don't seem be related to the changes in the source files. Could this be from other changes in the source? |
| @JasonGlazer To get a clean test, you'll need to merge from develop into this branch. In tortoisegit, switch to develop, pull, switch back to this branch, merge (from develop into this branch). Hopefully it merges without any conflicts. |
…/github.com/NREL/EnergyPlus into 84202670-DuplicateNodeInZoneConnCausesCrash
| Hopefully I merged it properly. It took me two times since the first time it did not have @Myoldmopar whitespace padding. |
…usesCrash Fixes crash when duplicate node names are used in zone connections object
Myoldmopar changed the title 4 participants
This is to fix Github issue #4577 , Pivotal #84202670. Change to a single line of code that is part of a error message so it is only executed when the error condition occurs. Thanks to LKL for identifying the problem code.