Skip to content

Cleanup IDD tags with extraneous spacing and incorrect casing#4645

Merged
jasondegraw merged 15 commits intoNatLabRockies:developfrom
rbuffat:idd_modifications
Feb 10, 2015
Merged

Cleanup IDD tags with extraneous spacing and incorrect casing#4645
jasondegraw merged 15 commits intoNatLabRockies:developfrom
rbuffat:idd_modifications

Conversation

@rbuffat
Copy link
Contributor

@rbuffat rbuffat commented Dec 23, 2014

@mjwitte @Myoldmopar
new PR to replace #4609

@mjwitte
Copy link
Contributor

mjwitte commented Dec 24, 2014

@rbuffat That's better :-) Thanks. Will review.

@nrel-bot
Copy link

@rbuffat @lgentile it has been 7 days since this pull request was last updated.

@nrel-bot
Copy link

nrel-bot commented Jan 7, 2015

@rbuffat @lgentile it has been 7 days since this pull request was last updated.

4 similar comments
@nrel-bot
Copy link

@rbuffat @lgentile it has been 7 days since this pull request was last updated.

@nrel-bot
Copy link

@rbuffat @lgentile it has been 7 days since this pull request was last updated.

@nrel-bot
Copy link

@rbuffat @lgentile it has been 7 days since this pull request was last updated.

@nrel-bot
Copy link

nrel-bot commented Feb 4, 2015

@rbuffat @lgentile it has been 7 days since this pull request was last updated.

@jasondegraw
Copy link
Member

@rbuffat Could you merge develop into your branch? That may fix the continuous integration failures and then we can get this merged.

@rbuffat
Copy link
Contributor Author

rbuffat commented Feb 9, 2015

after 27.12.2014 the failing tests were similar to
boto.exception.S3ResponseError: S3ResponseError: 403 Forbidden
but now that seems to have changed. I synced with upstream, lets look what the CI says

@jasondegraw
Copy link
Member

@rbuffat Looks like everything from CI is good, so I'll merge this shortly. Thanks for your contribution!

jasondegraw added a commit that referenced this pull request Feb 10, 2015
IDD modifications to fix spacing issues, normalize capitalization
@jasondegraw jasondegraw merged commit a50fae9 into NatLabRockies:develop Feb 10, 2015
@rbuffat rbuffat deleted the idd_modifications branch February 10, 2015 19:06
@Myoldmopar Myoldmopar changed the title Idd modifications Cleanup IDD tags with extraneous spacing and incorrect casing Mar 7, 2015
@Myoldmopar Myoldmopar added the Defect Includes code to repair a defect in EnergyPlus label Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus

5 participants