Should Select onChange emit value: T and not value: Key?

[ik-southpole]

At the moment, SelectProps extends from ValueBase<ValueType<M>, ChangeValueType<M>> (see the second generic) which will result in ValueBase#onChange not using T but Key.

This complicates usage of Select with TypeScript enums because it requires type casting. Do you think we can consider using T?

enum MyValue { A, B, C } // Actual <Select<MyValue> onChange={(value: Key) => { ... } }> ... </Select> // Expected <Select<MyValue> onChange={(value: MyValue) => { ... } }> ... </Select>

[snowystinger]

That would unfortunately be a breaking change to implement.

The reason it is this way is so that the value of onChange can be immediately applied to value

let [value, setValue] = useState('foo'); <Select value={value} onChange={setValue}> ... </Select> 

In addition, this is closer to the native api and closer to what is in the native input that backs this component.