Update node.js, homebrew, react-bootstrap #1992
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
naomi-lgbt reviewed May 22, 2023
lib/docs/scrapers/node.rb Outdated
| self.base_url = 'https://nodejs.org/api/' | ||
| end | ||
| | ||
| version '19 LTS' do |
Author
There was a problem hiding this comment.
Sorry, since version 19 is not an LTS release and its EOL is approaching in about a week, it should not be listed, ig.
TechQuery suggested changes Jun 8, 2023
Co-authored-by: South Drifted <shiy2008@gmail.com>
simon04 requested changes Jun 11, 2023
Contributor
simon04 left a comment
simon04 left a comment There was a problem hiding this comment.
> bundle exec thor docs:generate --force --package react_bootstrap ERROR: https://react-bootstrap.github.io/docs/layout/breakpoints/ NoMethodError: undefined method `content' for nil:NilClass TechQuery approved these changes Jul 3, 2023
Contributor
| Some pages needs some more tuning/cleaning: http://localhost:9292/react_bootstrap/docs/forms/select/index -Result -Loading... -Live Editor
http://localhost:9292/react_bootstrap/docs/getting-started/why-react-bootstrap/index
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
about_tmpl.coffeematches its data inself.attributionSOURCEfile inpublic/icons/your_scraper_name/are up-to-date if the documentation has a custom iconself.linkscontains up-to-date urls ifself.linksis defined