Add semanticdb test for #11693 #12599
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
scala#11693 > scala3-compiler-bootstrapped/Test/runMain dotty.tools.dotc.semanticdb.updateExpect
bishabosha requested changes May 25, 2021
Member
There was a problem hiding this comment.
Thank you for opening this, unfortunately, the problem described in #11693 is still not fixed, as can be seen on the first line of the test file in this PR:
https://github.com/lampepfl/dotty/blob/78c9bc58d330cd2945c26d98fb9ddc215fe93a11/tests/semanticdb/expect/toplevel.expect.scala#L1
The problem is that there is any occurrence of the /*<-_empty_::toplevel$package.*/ definition, rather than only it appearing next to a given - this happens wherever the first top level definition in the file exists
Member Author
Ah, I see, thank you for the feedback! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#11693
I'm not sure which commit changed the semanticdb behavior, but it looks like already somehow fixed. Added regression tests by adding a code to
toplevel.scalaand run:sbt > scala3-compiler-bootstrapped/Test/runMain dotty.tools.dotc.semanticdb.updateExpect