fix SQLSRV throws for method_exists() #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pdo_sqlsrv driver 5.9.0 on mac throws an exception for any call on method_exists(). (see microsoft/msphpsql/issues/1306) executeStatement() is a DBAL-method, exec() is PDO. exclude method_exists() check for PDO type of connections
| Thanks for your pull request! We love contributions. However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony repository. It is used by Composer to allow developers to depend on specific Symfony components. If you want to contribute, you should instead open a pull request on the main repository: https://github.com/symfony/symfony Thank you for your contribution! PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
pdo_sqlsrv driver 5.9.0 on mac throws an exception for any call on method_exists().
(see microsoft/msphpsql/issues/1306)
executeStatement() is a DBAL-method, exec() is PDO.
exclude method_exists() check for PDO type of connections