Skip to content

Fix use effect example #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 1, 2018
Merged

Fix use effect example #3

merged 4 commits into from
Nov 1, 2018

Conversation

@rwieruch
Copy link
Member

@rwieruch rwieruch commented Nov 1, 2018

Hooks Misconceptions:

  • clean up function runs not only for unmounting but also after each render
  • stale state is a thing with hooks too
@rwieruch rwieruch merged commit 83134cb into master Nov 1, 2018
stepanh
stepanh reviewed Nov 26, 2018
View reviewed changes
src/useEffect-example/index.js
);
}

return () => clearInterval(interval);
Copy link

@stepanh stepanh Nov 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rwieruch , in case that isOn === false, this will do clearInterval(undefined). It doesn't break anything, but it would be IMHO nicer to only run clearInterval for isOn === true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@rwieruch @stepanh