Client only routes #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Hi @fkoessler thanks for your work. I checked out the branch. Everything works like expected. However, there is one error showing up in the developer console which isn't there for the master version. Do you know anything about it? The other warning about "can't set state on unmounted component" happened before, but in this version it seems to happen more often than before. I am not sure why that's the case. Do you think it's better in general to have everything handled by the client routes now? It seemed to work perfectly with the server-side handled routes before. Maybe I would add this PR as reference to the README.md but keep the original version for now. What do you think? |
Author
| Hello @rwieruch, The permission denied error happens when you try a read / write on the database where you don't have permission. Concerning the warning can't set state on unmounted component. I don't think client routes are inherently better, I think it's a design choice. Feel free to merge the PR or not, both are fine with me :) |
Member
| Hi @fkoessler thanks for your input! 💯 I played a bit more around with Gatsby over the weekend and had to refactor the project (#11), because Regarding the client/server routes, I would keep them as server routes now. Both versions work and I would keeo your PR as reference to it. However, since Gatsby's primary goal is to work with server routes, I would keep it that way for now. Thanks again for your input. Helped me a lot to figure things out :) PS.: I have seen that the App component I had before was redundant, because it was actually never used. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello Robin,
As requested, this is a PR to have the project use client only routes for private portions of the site and use @reach/router for navigation as recommanded in the GatsbyJS docs.
Also I added two small fixes:
Let me know what you think.