changeset: 84028:93f4b32fc95c user: Victor Stinner date: Wed Jun 05 00:13:51 2013 +0200 files: Objects/namespaceobject.c description: Issue #9566: Fix a compiler warning on Windows 64-bit in namespace_init() The result type is int, return -1 to avoid a compiler warning (cast Py_ssize_t to int). PyObject_Size() can only fail with -1, and anyway a constructor should return -1 on error, not an arbitrary negative number. diff -r 52075f60719e -r 93f4b32fc95c Objects/namespaceobject.c --- a/Objects/namespaceobject.c Wed Jun 05 00:11:34 2013 +0200 +++ b/Objects/namespaceobject.c Wed Jun 05 00:13:51 2013 +0200 @@ -44,7 +44,7 @@ if (args != NULL) { Py_ssize_t argcount = PyObject_Size(args); if (argcount < 0) - return argcount; + return -1; else if (argcount > 0) { PyErr_Format(PyExc_TypeError, "no positional arguments expected"); return -1;