You are not logged in. Your edit will be placed in a queue until it is peer reviewed.
We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.
Required fields*
- One subtle difference I think might be in how permissions are handled. I believe the M1 approach would only check on the new controller. Whereas with the above the plugin doing the authentication would still execute (ie if you don't have access to ModuleA you also don't have access to ModuleB).Kristof at Fooman– Kristof at Fooman2017-05-18 22:13:30 +00:00Commented May 18, 2017 at 22:13
- you would also potentially disable plugins on the original controller action if you implement this plugin without calling the original method, which would be especially problematic to 3rd patry vendorsDavid Verholen– David Verholen2017-05-18 22:24:43 +00:00Commented May 18, 2017 at 22:24
- on the other hand, this might be exactly what you want in most cases when overriding controller actions. In a beautiful future maybe, the core controllers only execute functionality of models and you can just recompose themDavid Verholen– David Verholen2017-05-18 22:30:09 +00:00Commented May 18, 2017 at 22:30
- Will need to consider layout updates when doing this.benmarks– benmarks2017-05-19 16:49:56 +00:00Commented May 19, 2017 at 16:49
Add a comment |
How to Edit
- Correct minor typos or mistakes
- Clarify meaning without changing it
- Add related resources or links
- Always respect the author’s intent
- Don’t use edits to reply to the author
How to Format
- create code fences with backticks ` or tildes ~ ```
like so
``` - add language identifier to highlight code ```python
def function(foo):
print(foo)
``` - put returns between paragraphs
- for linebreak add 2 spaces at end
- _italic_ or **bold**
- indent code by 4 spaces
- backtick escapes
`like _so_` - quote by placing > at start of line
- to make links (use https whenever possible) <https://example.com>[example](https://example.com)<a href="https://example.com">example</a>
How to Tag
A tag is a keyword or label that categorizes your question with other, similar questions. Choose one or more (up to 5) tags that will help answerers to find and interpret your question.
- complete the sentence: my question is about...
- use tags that describe things or concepts that are essential, not incidental to your question
- favor using existing popular tags
- read the descriptions that appear below the tag
If your question is primarily about a topic for which you can't find a tag:
- combine multiple words into single-words with hyphens (e.g. magento-1.9), up to a maximum of 35 characters
- creating new tags is a privilege; if you can't yet create a tag you need, then post this question without it, then ask the community to create it for you
default