Skip to main content
added 83 characters in body
Source Link
syb0rg
  • 21.9k
  • 17
  • 24

I feel like should not be burned, and is a valid part of a code review (if included with the question).

Take this example:

Test/ ├── .gitignore ├── README ├── CMakeLists.txt ├── src/ │ ├── audio/ │ │ └── ... │ ├── web/ │ │ └── ... │ └── ... ├── build/ └── cmake/ ├── FindLibSndFile.cmake └── FindPortaudio.cmake 

If there were a better way to structure my files, I would want to know how and why. Granted, this should not be the only thing reviewed; but it is certainly an aspect of a code review. How the files are structured could also affect the code and how it is programmed.

I feel like should not be burned, and is a valid part of a code review (if included with the question).

Take this example:

Test/ ├── .gitignore ├── README ├── CMakeLists.txt ├── src/ │ ├── audio/ │ │ └── ... │ ├── web/ │ │ └── ... │ └── ... ├── build/ └── cmake/ ├── FindLibSndFile.cmake └── FindPortaudio.cmake 

If there were a better way to structure my files, I would want to know how and why. Granted, this should not be the only thing reviewed; but it is certainly an aspect of a code review.

I feel like should not be burned, and is a valid part of a code review (if included with the question).

Take this example:

Test/ ├── .gitignore ├── README ├── CMakeLists.txt ├── src/ │ ├── audio/ │ │ └── ... │ ├── web/ │ │ └── ... │ └── ... ├── build/ └── cmake/ ├── FindLibSndFile.cmake └── FindPortaudio.cmake 

If there were a better way to structure my files, I would want to know how and why. Granted, this should not be the only thing reviewed; but it is certainly an aspect of a code review. How the files are structured could also affect the code and how it is programmed.

Source Link
syb0rg
  • 21.9k
  • 17
  • 24

I feel like should not be burned, and is a valid part of a code review (if included with the question).

Take this example:

Test/ ├── .gitignore ├── README ├── CMakeLists.txt ├── src/ │ ├── audio/ │ │ └── ... │ ├── web/ │ │ └── ... │ └── ... ├── build/ └── cmake/ ├── FindLibSndFile.cmake └── FindPortaudio.cmake 

If there were a better way to structure my files, I would want to know how and why. Granted, this should not be the only thing reviewed; but it is certainly an aspect of a code review.