Skip to main content
9 events
when toggle format what by license comment
Jun 10, 2020 at 13:09 history edited CommunityBot
Commonmark migration
May 23, 2017 at 9:46 history edited Toby Speight CC BY-SA 3.0
Just a tiny spelling mistake
Oct 7, 2014 at 8:30 comment added RubberDuck "Remember, Code Review should be a place that is fun to review things on too. If it does not look like fun, then don't do it." - Thank you for the reminder. ++
Oct 5, 2014 at 22:24 comment added Emily L. Non-programming-challenge type performance problems are more about the code than their challenge siblings in my opinion as they are actually solving a real problem in probably a larger code base where the code quality matters as opposed to a challenge where only the correct time complexity and algorithm correctness matter. So yes only with those questions that pertain to programming challenges.
Oct 5, 2014 at 17:05 comment added rolfl Mod Almost all questions on Code Review tagged performance require algorithm rewrites. Sometimes it is because it is just too slow to get things done in the day, other times it is because some online judge determined it was too slow. Regardless of whether an online judge made the determination or not, all performance questions inevitably require similar reviews - "Do things differently!". Is your concern with performance questions in general, or only those that are online-judged?
Oct 5, 2014 at 16:39 comment added Emily L. I agree that performance aspects are an important part of a code review. But in the case of TLE and programming challenge type questions I feel that the question is more about the algorithm than the actual code, in these questions the actual implementation is most often irrelevant. And then it isn't a code review any more but rather a "help me with this algorithm" question masqueraded as a code review. I guess this is what grinds my gears.
Oct 5, 2014 at 9:48 history edited Simon Forsberg CC BY-SA 3.0
tiny typo
Oct 5, 2014 at 0:05 history edited rolflMod CC BY-SA 3.0
typos
Oct 4, 2014 at 23:58 history answered rolflMod CC BY-SA 3.0