Edit - Software Engineering Stack Exchange

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

Rev

I only use boolean arguments to control behavior in private methods (as shown here). But the problem: If some dufus decides to increase the visibility of FooInternal in the future, then what?

ADTC
– ADTC

2014-10-15 07:35:29 +00:00
Commented Oct 15, 2014 at 7:35
Actually, I'd go another route. The code inside FooInternal should be split into 4 pieces: 2 functions to handle the Boolean true/false cases, one for the work that happens before, and another for the work that happens after. Then, your Foo1 becomes: { doWork(); HandleTrueCase(); doMoreWork() }. Ideally, the doWork and doMoreWork functions are each broken down into (one or more) meaningful chunks of discrete actions (i.e. as separate functions), not just two functions for the sake of splitting.

jpaugh
– jpaugh

2017-06-14 19:44:28 +00:00
Commented Jun 14, 2017 at 19:44
That was a "simple direct to the point" example.

abdalmonem
– abdalmonem

2025-01-05 09:55:43 +00:00
Commented Jan 5 at 9:55

Add a comment |

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »