Edit - Software Engineering Stack Exchange

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

Rev

3

Awesome answer. I actually state a preference for work where other devs will be using stuff that I wrote heavily because getting that scrutiny/feedback is invaluable. Also, @w0051977 it was silly of you to be on such a large project with no input from teammates for as long as you were. Given your app development experience I'd call that management fail. If you ever find yourself in a similar situation on another project, ask for periodic code review.

Erik Reppen
– Erik Reppen

2013-09-04 15:36:50 +00:00
Commented Sep 4, 2013 at 15:36
@ErikReppen: Thanks. I totally agree with you, it looks like there's a major management fail there. But unfortunately I'd bet the OP will still get flak for the overall failure and code quality. It's his code, and his fault for not demanding more reviews earlier as well.

haylem
– haylem

2013-09-04 15:43:32 +00:00
Commented Sep 4, 2013 at 15:43
2

This is an incredibly awesome answer. Thanks for sharing!

Simon Whitehead
– Simon Whitehead

2013-09-05 13:17:12 +00:00
Commented Sep 5, 2013 at 13:17
One thing I should note from my experience: Do not pre-emptively prepare your mind for a beating, when it's really just calm criticism that will lead to better code. "Hey, I think if you call this method with a null argument, it actually crashes the entire database." "Yeah, well you shouldn't call it with a null argument!! It's Joel's fault for always doing it that way in the main project! I didn't have the tools to do it another way! Write it yourself why don't you?!"

Katana314
– Katana314

2013-09-05 15:20:15 +00:00
Commented Sep 5, 2013 at 15:20
1

@haylem: :(. Also, this is one of the most extensive and detailed answers I've seen in a long time. There are so many positive aspects that it's difficult to pick out just one for the +1.

Joel
– Joel

2013-09-07 06:07:23 +00:00
Commented Sep 7, 2013 at 6:07

| Show 4 more comments

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »