Edit - Software Engineering Stack Exchange

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

Rev

thanks, I find it a bit strange to have some DTO/container to hold just repository reference, but yes I agree it's a good way to reduce number of parameters in constructor. What do you think about my 2nd approach? To be honest, I quite like the idea of the 2nd approach, since it looks clean to me, although there are some drawbacks as I mentioned

Phuong Nguyen
– Phuong Nguyen

2014-10-10 16:09:51 +00:00
Commented Oct 10, 2014 at 16:09
It might not only just hold it. Imagine credentials. In a simple form, they consist only of a userId and a password. Same goes for a simple geo-coordinate(s) class. But they has to fit together by business logics / semantics. It's not good to put 2 things into a class just to pass only one argument. Actually your 2nd approach is exactly what I suggested but instead of putting together what fits together it is putting everything together. That hides what your method really needs to work and is like giving the method all 3 IRepository arguments (in grouped form) but it uses only few of them.

valenterry
– valenterry

2014-10-10 18:57:16 +00:00
Commented Oct 10, 2014 at 18:57

Add a comment |

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »