Edit - Software Engineering Stack Exchange

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Whether in separate patches or not, a broken window policy needs to be instated with legacy code, whether that policy is "don't fix broken windows" or "only in [methods/classes/files?] that are touched by the current patch". In my experience, preventing developers from fixing broken windows is toxic to team morale.

Dewi Morgan
– Dewi Morgan

2016-10-21 15:44:02 +00:00
Commented Oct 21, 2016 at 15:44
1

True, but forcing them to fix every broken window in a module before their one-line change passes review is equally toxic.

Useless
– Useless

2016-10-21 15:45:59 +00:00
Commented Oct 21, 2016 at 15:45
Agreed! A policy that's been thrashed out by the team, rather than externally imposed, is the only kind that can work, I feel.

Dewi Morgan
– Dewi Morgan

2016-10-21 15:50:50 +00:00
Commented Oct 21, 2016 at 15:50

Add a comment |

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »