Timeline for Coding standard for clarity: comment every line of code?
Current License: CC BY-SA 3.0
10 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Nov 23, 2016 at 14:40 | comment | added | Andrew T Finnell | The same file, Linus himself, on line 322 he did NOT put a space between the function and the open paren. Then on line 328, he did put a space. The essence of these two lines of code has wasted days and days of my life in Code Reviews that do not improve quality, because someone wanted to argument over a space. | |
| Nov 23, 2016 at 14:37 | comment | added | Andrew T Finnell | I am in 99.9% agreement with this answer. The Coding Standard is meant to be the thing developers point to when a debate happens at Code Review. Code reviewing is meant to enrich the product not start wars. So many wars I have seen instigated by Code Reviews with no Coding Standard. I dare say that if you cannot automate the checking of the items in the coding standard it should be in there. A Code review is the time to impart 'common sense' to other less experienced developers. It's not the time to fight over the naming of variables. linux/kernel/gen_init_cpio.c line 335. | |
| Nov 22, 2016 at 14:10 | comment | added | JacquesB | @JohnR.Strohm: My experience have been much more positive than yours, but I have also seen how the the use of common sense can be actively discouraged by mechanically enforcing rules. | |
| S Nov 21, 2016 at 12:16 | history | suggested | martin | CC BY-SA 3.0 | fixed a typo |
| Nov 21, 2016 at 5:53 | review | Suggested edits | |||
| S Nov 21, 2016 at 12:16 | |||||
| Nov 20, 2016 at 22:15 | comment | added | Michael Durrant | in_programming no.. real world oh yeah but its just a term for real world expereienced knowledge | |
| Nov 20, 2016 at 18:41 | comment | added | whatsisname | There is no such thing as common sense. | |
| Nov 20, 2016 at 18:25 | comment | added | John R. Strohm | One of the many things I have learned after over 40 years in this racket is that common sense is not at all common. | |
| Nov 20, 2016 at 18:23 | history | edited | JacquesB | CC BY-SA 3.0 | added 287 characters in body |
| Nov 20, 2016 at 18:11 | history | answered | JacquesB | CC BY-SA 3.0 |