You are not logged in. Your edit will be placed in a queue until it is peer reviewed.
We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.
- 2You don't just return the code saying "refactor. now" - why? I received such review comments at least once and last time I remember it turned out helpful and correct. I had to rewrite big chunk of code from the scratch and this was the right thing to do because looking back I saw it myself that old code was an unsalvageable mess. Reviewer was simply enough qualified to notice that (and I apparently wasn't)gnat– gnat2016-12-16 21:20:59 +00:00Commented Dec 16, 2016 at 21:20
- 4@gnat: For one, because it's rude. You look better when you explain what's wrong with the code and take effort to help the other person improve it. In a large company doing it otherwise may get you out of the door quickly. Especially if you reviewing a more senior person's code.Victor Zakharov– Victor Zakharov2016-12-16 21:24:13 +00:00Commented Dec 16, 2016 at 21:24
- that case I referred above, it was in large established company that just happened to be careful enough about not getting out of the door their most qualified developers, at least not on the grounds of directly sharing their technical expertise when asked tognat– gnat2016-12-16 21:29:01 +00:00Commented Dec 16, 2016 at 21:29
- 1@gnat: The approach "refactor. now" may work downwards, i.e. when a senior developer with 10+ years of experience says to refactor to a junior developer who was hired 1 month ago with no experience, or similar situation. Upwards - you may have a problem. Because you may not know how much experience the other developer has, it's safe to assume respect as default behavior. It won't hurt you for sure.Victor Zakharov– Victor Zakharov2016-12-16 21:39:34 +00:00Commented Dec 16, 2016 at 21:39
- 1@Neolisk: An experienced developer who had to write code under time pressure and knows it isn't good enough may be only too happy if you reject the code, giving him time and an excuse to improve it. The PHB deciding it's good enough makes the dev unhappy; the reviewer deciding it's not good enough makes him happy.gnasher729– gnasher7292016-12-18 14:09:09 +00:00Commented Dec 18, 2016 at 14:09
| Show 1 more comment
How to Edit
- Correct minor typos or mistakes
- Clarify meaning without changing it
- Add related resources or links
- Always respect the author’s intent
- Don’t use edits to reply to the author
How to Format
- create code fences with backticks ` or tildes ~ ```
like so
``` - add language identifier to highlight code ```python
def function(foo):
print(foo)
``` - put returns between paragraphs
- for linebreak add 2 spaces at end
- _italic_ or **bold**
- indent code by 4 spaces
- backtick escapes
`like _so_` - quote by placing > at start of line
- to make links (use https whenever possible) <https://example.com>[example](https://example.com)<a href="https://example.com">example</a>
How to Tag
A tag is a keyword or label that categorizes your question with other, similar questions. Choose one or more (up to 5) tags that will help answerers to find and interpret your question.
- complete the sentence: my question is about...
- use tags that describe things or concepts that are essential, not incidental to your question
- favor using existing popular tags
- read the descriptions that appear below the tag
If your question is primarily about a topic for which you can't find a tag:
- combine multiple words into single-words with hyphens (e.g. design-patterns), up to a maximum of 35 characters
- creating new tags is a privilege; if you can't yet create a tag you need, then post this question without it, then ask the community to create it for you