You are not logged in. Your edit will be placed in a queue until it is peer reviewed.
We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.
Required fields*
- How do you unit test a logger? Do you have to moc IO? That seems obnoxious.Krupip– Krupip2018-12-14 21:47:39 +00:00Commented Dec 14, 2018 at 21:47
- 1@opa if your logger has interesting business logic you isolate that and unit test it. Boring code that confirms we have a file system doesn't need unit testing.candied_orange– candied_orange2018-12-14 22:36:02 +00:00Commented Dec 14, 2018 at 22:36
- @candied_orange So now you have to expose internal logic? Because how else are you going to separate the string generated by the logger before it is output to a file with separating it out into a private method?Krupip– Krupip2018-12-14 22:54:09 +00:00Commented Dec 14, 2018 at 22:54
- @opa If you need to test that you can do it by passing in your own stream. Unit tests test units not system resources.candied_orange– candied_orange2018-12-14 23:19:00 +00:00Commented Dec 14, 2018 at 23:19
- 1I think it's an answer because when I look at the actual code I found out that there is an asynchronous call of the main thread. Thus, the assertation is called after the delay, which is unacceptable for the speed of the unit test. Asynchronous call of the main thread should be mocked, in this case, I can say that it will be a unit test.Vladimir Kaltyrin– Vladimir Kaltyrin2018-12-21 09:54:00 +00:00Commented Dec 21, 2018 at 9:54
| Show 8 more comments
How to Edit
- Correct minor typos or mistakes
- Clarify meaning without changing it
- Add related resources or links
- Always respect the author’s intent
- Don’t use edits to reply to the author
How to Format
- create code fences with backticks ` or tildes ~ ```
like so
``` - add language identifier to highlight code ```python
def function(foo):
print(foo)
``` - put returns between paragraphs
- for linebreak add 2 spaces at end
- _italic_ or **bold**
- indent code by 4 spaces
- backtick escapes
`like _so_` - quote by placing > at start of line
- to make links (use https whenever possible) <https://example.com>[example](https://example.com)<a href="https://example.com">example</a>
How to Tag
A tag is a keyword or label that categorizes your question with other, similar questions. Choose one or more (up to 5) tags that will help answerers to find and interpret your question.
- complete the sentence: my question is about...
- use tags that describe things or concepts that are essential, not incidental to your question
- favor using existing popular tags
- read the descriptions that appear below the tag
If your question is primarily about a topic for which you can't find a tag:
- combine multiple words into single-words with hyphens (e.g. design-patterns), up to a maximum of 35 characters
- creating new tags is a privilege; if you can't yet create a tag you need, then post this question without it, then ask the community to create it for you