You are not logged in. Your edit will be placed in a queue until it is peer reviewed.
We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.
- ` Http client = GetcurrentAccessToken(_httpClient);` So this would leave an underlying socket open?8protons– 8protons2020-11-15 19:08:01 +00:00Commented Nov 15, 2020 at 19:08
- @8protons Yes, for a while. In Windows it's around 4 minutes. So ideally you would not create new HttpClients, and instead reuse one instance of it throughout the whole application run time to avoid having too many open sockets.Aleksander– Aleksander2020-11-15 20:32:33 +00:00Commented Nov 15, 2020 at 20:32
- Just to add to this, HttpClient is an awful footgun as this excellent blog post from 2016 shows ( aspnetmonsters.com/2016/08/2016-08-27-httpclientwrong ). Ive personally seen this happen in production, and it is awful to troubleshoot. Always reuse one instance of it if you use it. Or use some of the other http client libraries on .net that doesnt have this awful design built in.wasatz– wasatz2020-11-16 07:07:01 +00:00Commented Nov 16, 2020 at 7:07
- @Aleksander Are you sure? Because the initial http client is managed watched by IHttpClientFactory. When I created a new instance and closed the original, the clone seemed to close as well.8protons– 8protons2020-11-16 17:43:41 +00:00Commented Nov 16, 2020 at 17:43
- @8protons How and where are you creating a new instance?Aleksander– Aleksander2020-11-16 18:18:41 +00:00Commented Nov 16, 2020 at 18:18
| Show 4 more comments
How to Edit
- Correct minor typos or mistakes
- Clarify meaning without changing it
- Add related resources or links
- Always respect the author’s intent
- Don’t use edits to reply to the author
How to Format
- create code fences with backticks ` or tildes ~ ```
like so
``` - add language identifier to highlight code ```python
def function(foo):
print(foo)
``` - put returns between paragraphs
- for linebreak add 2 spaces at end
- _italic_ or **bold**
- indent code by 4 spaces
- backtick escapes
`like _so_` - quote by placing > at start of line
- to make links (use https whenever possible) <https://example.com>[example](https://example.com)<a href="https://example.com">example</a>
How to Tag
A tag is a keyword or label that categorizes your question with other, similar questions. Choose one or more (up to 5) tags that will help answerers to find and interpret your question.
- complete the sentence: my question is about...
- use tags that describe things or concepts that are essential, not incidental to your question
- favor using existing popular tags
- read the descriptions that appear below the tag
If your question is primarily about a topic for which you can't find a tag:
- combine multiple words into single-words with hyphens (e.g. design-patterns), up to a maximum of 35 characters
- creating new tags is a privilege; if you can't yet create a tag you need, then post this question without it, then ask the community to create it for you
lang-cs