Timeline for How do you make people accept code review?
Current License: CC BY-SA 2.5
11 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| May 2, 2011 at 0:37 | history | made wiki | Post Made Community Wiki | ||
| May 1, 2011 at 20:27 | comment | added | Job | Some companies are not wise and keep code review statistics in some sort of system. Then it can drive a fear of being a candidate to be laid off. | |
| May 1, 2011 at 15:08 | history | migrated | from stackoverflow.com (revisions) | ||
| Oct 9, 2010 at 8:46 | comment | added | gkdm | I used this technique for quite some time, always making sure one of my colleges reviews my code and than making corrections. Everyone loved giving the reviews and I was sure very soon they would want their code reviewed as well. I couldn't have been more wrong. | |
| Sep 16, 2009 at 3:49 | comment | added | Alex Baranosky | The smartest people are the ones most able to accept finding out they are wrong. find out where you are wrong, then make it right. But self-conscious "slow" folks avoid anything that makes them feel wrong;it hurts too much. this is just an error in thinking. They dont' see that it causes them to be stupid. Fear of stupidity creates more stupidity. | |
| Aug 21, 2009 at 11:05 | comment | added | Noon Silk | Indeed :) I'm sure we're in general agreement. Mainly I am saying I think the problem stems from false pride. Be proud of your ability to learn, not only your ability to know. | |
| Aug 21, 2009 at 11:02 | comment | added | Jon Skeet | @silky: It's not personal as in, "I'm not saying you're a bad person, I'm saying your code has problems." There's a big difference between attacking the code and attacking the person. If you go into a code review saying, "What were you thinking? Are you stupid or something?" then that's a problem :) | |
| Aug 21, 2009 at 11:00 | comment | added | Noon Silk | Well, I must disagree, a review is always personal, but the real trick is to realise there is no problem in being wrong. People stick to their views too much as they think it is weak to be wrong; I think it is weak to not be wise, admit mistakes, learn, and move on. | |
| Aug 21, 2009 at 10:58 | comment | added | user1274 | +1 for being a student of the human condition, I'll admit I'm guilty of the last sentence | |
| Aug 21, 2009 at 9:33 | comment | added | rahul | +100 for 'people take code reviews too personally' | |
| Aug 21, 2009 at 7:35 | history | answered | Jon Skeet | CC BY-SA 2.5 |