Timeline for How can I tactfully suggest improvements to others' badly designed code during review?
Current License: CC BY-SA 3.0
6 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| S Oct 28, 2016 at 10:22 | history | suggested | Declan McKenna | CC BY-SA 3.0 | Fixed grammar |
| Oct 28, 2016 at 8:40 | review | Suggested edits | |||
| S Oct 28, 2016 at 10:22 | |||||
| Oct 11, 2011 at 18:32 | comment | added | Spencer Rathbun | True. But I include that underneath the shop itself not caring. Your devs may not know about some functionality within the current toolset, especially if management never bothered to create standards. Secondly, many IDEs are very large, with a huge feature set. I've been using vim for a couple years now, and I still don't know all the different things I can do with it. If you dropped me into Visual Studio, I'd leave 90% of the fuctionality untouched until I had time to dig through it. Then I might not remember it. | |
| Oct 11, 2011 at 18:24 | comment | added | Kramii | @Spencer: I couldn't agree more. At the same time, I get frustrated by developers who don't use the tools they've got - through ignorance of the function or benefits or plain laziness. Most modern IDEs have a built-in code formatting function that takes just a couple of keystrokes - yet some devs don't use it. | |
| Oct 11, 2011 at 14:19 | comment | added | Spencer Rathbun | +1 for use of automated tools. Shockingly, it seems many shops don't care enough to see what the developers tool kit looks like. Just because you've got source control, an editor, and a compiler, does not make your toolkit complete. | |
| Oct 11, 2011 at 6:13 | history | answered | Kramii | CC BY-SA 3.0 |