Timeline for How can I tactfully suggest improvements to others' badly designed code during review?
Current License: CC BY-SA 3.0
2 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Oct 28, 2016 at 21:31 | comment | added | gnasher729 | It's rare that I'd say "I wonder if it would be better to...". I'd only say that if I wasn't sure - in which case the author is free to think if it would be better or not and is free to change or not. I usually say "I would do X". (Sometimes I'll say "I would have done X, but your approach is better"). Which means I think X is better, but you can disagree. Or I'll say "this doesn't work" or "this is dangerous" and you better change it. Sometimes I'm told "this doesn't work", and usually I look at the code, I'll say "Oh shit", and then I fix it. | |
| Oct 11, 2011 at 19:25 | history | answered | Ed Staub | CC BY-SA 3.0 |