Edit - Software Engineering Stack Exchange

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

I've looked at GRASP before, and it's probably what really drove me to design Implementation #1. Though I am wondering, in keeping with what you said about splitting implementation, should I spread out the MVC architecture, instead of over User like I did in #2, but over all the modules (Login, Logout, etc...) in the user 'space'? i.e. LoginControl, LoginView, etc, etc... ?

Mike S
– Mike S

2011-11-10 11:16:06 +00:00
Commented Nov 10, 2011 at 11:16
SRP is basically function spaghetti in OOP clothing as far as I'm concerned. At best, it works for the interior of composite classes but it fails at intuitive easy-to-use interfaces in higher level objects. Higher level classes should represent problem domains, not functions with persistent vars. Excess separation of concerns before it was needed has been my #1 problem with the majority of legacy codebases I've inherited. Ultimately it's a violation of YAGNI and IMO probably originally a broader ideal turned into an antipattern to get that 'S' in SOLID.

Erik Reppen
– Erik Reppen

2013-07-17 19:09:11 +00:00
Commented Jul 17, 2013 at 19:09

Add a comment |

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »