Skip to main content

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

8
  • I really hate working on some old code, where some helper methods are spread throughout the whole codebase. Usually I start putting them in some helper classes, but this is so much work. Commented Dec 5, 2011 at 8:34
  • 34
    On the other hand, when you try to hard to avoid duplicated code, you might create unwanted dependencies (tight coupling) that hurts maintainability. The big questions is if two parts of code are "accidentally similar" or "similar on purpose". In the first case, it's perfectly ok if one copy is changed and the other one untouched. For example, printing delivery notes and printing invoices might initially be identical, but later, prices are ommited from the delivery notes. In the later case, changing one copy means that all other copies must be changed as well. That's when it becomes an issue. Commented Dec 5, 2011 at 8:51
  • +1 bringing up (bad) memories, but it was the worst maintenance nightmare. Commented Dec 5, 2011 at 10:21
  • The work case of copy and paste I recall had 12 copies of code to handle 6 identified cases. Fortunately, it was a stand-alone module, so it was possible to avoid upgrading it when the rest of the code was upgraded. We couldn't even cleanly parse what it was doing to rewrite it. Commented Dec 5, 2011 at 12:44
  • 4
    "logged resulting in yet another fix OF THE SAME THING" - Almost accurate, but you will actually get "Two or more DIFFERENT fixes OF THE SAME THING" Commented Dec 5, 2011 at 13:11