Skip to main content
Software Engineering

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

7
  • I can't see major nor concept errors. You are doing it well. But let's wait for more expert opinions :) Commented Jan 3, 2012 at 14:15
  • @Silver89 -- can you put your code up somewhere? (github or the like?) Commented Jan 3, 2012 at 14:17
  • 1
    whether you got the OO parts right or not is impossible to say from the very little code you show. We'd need to see your classes. If you need guidance in refactoring the procedural codebase have a look at sourcemaking.com/refactoring/… Commented Jan 3, 2012 at 14:21
  • 1
    There isn't enough info in your question, to discuss your approach. You should expand it and give us a better view of the whole hierarchy (not so much code, but how your classes interact with each other) and tell us exactly what you're doing and why. Or you could simply post your classes for review at Code Review Stack Exchange. Commented Jan 3, 2012 at 19:58
  • You might want to consider implementing an autoloader instead of explicitly requiring everything. Commented Jan 4, 2012 at 10:12