Timeline for What are common code review processes and what is considered bad?
Current License: CC BY-SA 3.0
6 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Dec 19, 2013 at 22:10 | comment | added | webbiedave | @user1207047: You shouldn't accept an answer because you like one of the comments underneath as it goes against the standards and purpose of the site (I think I'm sensing a pattern here). There is upvote comment functionality for that. | |
| Dec 19, 2013 at 20:54 | comment | added | user1207047 | You know @Dunk, I think you're right here. Your comment really hit home and I accepted this answer since I don't think I can accept a comment. I am an "outsider" to this group and realize now why the inner circle is getting better and quicker reviews and those outside aren't. I was "forced" onto this team by management, yes and we are "forced" to work together. So this sounds very reasonable and a logical explanation as to why it's harsher. That or I really stink at coding. Only way to figure that out is to go to another group/company and see for myself. | |
| Dec 19, 2013 at 20:53 | vote | accept | user1207047 | ||
| Dec 19, 2013 at 20:12 | comment | added | Dunk | I have seen it happen where a specific developer is given lots of action items from their reviews in order to prevent them from messing up code in other areas of the program. But that would be for an exceptionally poor developer who is "forced" onto the project and the lead can't get rid of them because of management decisions. | |
| Dec 19, 2013 at 20:11 | comment | added | user1207047 | I have tried many times to ask for priority of comments. I get back something like "nice to have" and "required." Turns out a vast majority of them are "required." | |
| Dec 19, 2013 at 20:03 | history | answered | Doc Brown | CC BY-SA 3.0 |