Edit - Software Engineering Stack Exchange

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

1

How could you possibly engage in a code review if you don't want to be directly confronted with your work?

JeffO
– JeffO

2015-05-19 19:00:29 +00:00
Commented May 19, 2015 at 19:00
My team schedules a code review at the end of each sprint/iteration,etc or when a certain milestone or has been reached. We have two defined REVIEW tags, REVIEW_R for dead/pointless code for requirement validation and REVIEW_Q for code quality concerns. Either myself (lead) or the project manager will copy all REVIEW_* comments from the task list in visual studio. The REVIEW_Q list is dumped into a powerpoint presentation along with the code from each.

Code.Combustion
– Code.Combustion

2015-05-20 17:38:32 +00:00
Commented May 20, 2015 at 17:38
The REVIEW_R list is sent to our requirements team (which consists of a few developers, the requirements manager and a tester/QA/functional). They either concur with the observation of the REVIEW_R comment or they identify the requirement that this code fulfills. The updated REVIEW_R list, is added to the bottom of the powerpoint presentation. Finally, the development team hashes it out in a meeting and resulting changes are made. It becomes a group review, not just developerA telling developerB their code sucks. YMMV

Code.Combustion
– Code.Combustion

2015-05-20 17:38:59 +00:00
Commented May 20, 2015 at 17:38

Add a comment |

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »