Re: [Openvpn-devel] [PATCH release/2.4] configure.ac: fix building against static openssl

On 30/05/17 22:50, Steffan Karger wrote: > Instead of searching for both libssl and libcrypto, just search for > openssl as a whole (which depends on libssl and libcrypto). The previous > discovery order would result in "-lcrypto -lssl" link flags, while we > need "-lssl -lcrypto". > > Trac: #863 > > Signed-off-by: Steffan Karger <st...@ka...> > --- > This patch is for release/2.4 only, because this is already fixed in > master by commit 79ea67f77ca3afe91222f62e17df885a30409285. > > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 2406ad8..854634a 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -859,7 +859,7 @@ if test "${enable_crypto}" = "yes" -a "${with_crypto_library}" = "openssl"; then >	# if the user did not explicitly specify flags, try to autodetect >	PKG_CHECK_MODULES( >	[OPENSSL], > -	[libcrypto >= 0.9.8, libssl >= 0.9.8], > +	[openssl >= 0.9.8], > [have_openssl="yes"], >	[have_openssl="no"] # Provide if-not-found to prevent erroring out >	) > I vaguely remember we discussed the OpenSSL versions. On the Linux side, we shouldn't need to worry about anything older than 1.0.1. I do however vaguely remember someone mentioning some BSD distros still being on 0.9.8 ... or was it some other OS? ... Anyhow, do we need to care for them? This is release/2.4 we're talking about after all. If we really do care for supporting 0.9.8, in release/2.4 - I can give this an ACK. Otherwise, I think it might be better to backport 039a89c331e9b7998d804 + 79ea67f77ca3afe91222f. -- kind regards, David Sommerseth OpenVPN Technologies, Inc