Re: [Openvpn-devel] [PATCH] win: support for Visual Studio 2017

Acked-by: Simon Rozman <si...@ro...> From: Lev Stipakov <lst...@gm...> Sent: Sunday, September 30, 2018 7:19 AM To: Simon Rozman <si...@ro...> Cc: ope...@li... Subject: Re: [Openvpn-devel] [PATCH] win: support for Visual Studio 2017 Hi, I was very delighted to see this contribution. However, after hours of struggling to compile and prepare pre-requisites, I gave up my attempts to test this patch. The openvpn-build/msvc/build.bat was indeed helpful, though a bit outdated to be directly usable. Sorry, I probably have to state it more clear in email - I have prepared patch to openvpn-build as well, see https://github.com/OpenVPN/openvpn-build/pull/137 The new version should be usable out of the box. I don't think you need autoconf or anything besides VS2017 and ActiveState Perl. Certainly you are not supposed to copy or edit files manually. Here is build log from AppVeyor: https://ci.appveyor.com/project/lstipakov/openvpn-build/build/openvpn-build-19/job/kl2ky4ncbhiqw8gg?fullLog=true Now, I have begun to question the rationale of this patch... If it is too hard to setup building environment for me (Visual Studio is my daily working environment from 1998), We should sort it out. To build with VS you are only supposed to 1) clone openvpn-build 2) run msvc/build.bat 3) (optionally) open msvc/build.tmp/openvpn-master/openvpn.sln with Visual Studio IDE and enjoy coding Would have been nice to add Windows 10 ARM64 support, but remembered somebody needs to compile pre-requisites for ARM64 nightmare... Can TAP driver be compiled for ARM64? BTW, I have a patch in my forked repo re-establishing Visual Studio 2017 support for compiling openvpnserv.exe. I needed it to debug while developing support for multi-instances With this and openvpn-build patch I was able to debug (run and attach to process) both openvpn and openvpnserv.exe Best regards, Simon -- -Lev