Tabs.url is undefined

Question

I have no clue what I'm doing wrong here! This should be working I believe. I'm writing a chrome extension and this should get the current tab's url and set the html of #current-tab to the url (for testing purposes). The code successfully gets to the callback, but it says that tab.url is undefined when I put it in an alert box, and it does not put it's value in #current-tab. Here's the code I have:

$('#get-tab').click(function(){ chrome.tabs.query({"active" : true}, function(tab){ for (var i = 0; i < tab.length; i++) { alert(tab[i].url); $('#current-tab').append(tab[i].url); }; }); });

I initially did that (tab[i].url) as I knew that it returned an array, but that didn't seem to be working either, so I posted the script that I was trying instead, which didn't make much sense to me, but I was experimenting... See my edit above with my original code. — LICHEN
– LICHEN, Commented Nov 22, 2012 at 23:38

LICHEN · Accepted Answer · 2012-11-23 06:19:07Z

3

I figured out what was wrong! Apparently you need to reload the extension to refresh changes to the manifest file! I had added the permissions later, but had not reloaded the extensions in the extension manager, so the change had not taken effect! We're rolling now!

answered Nov 23, 2012 at 6:19

LICHEN

6961 gold badge5 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

RocketDonkey Over a year ago

Haha, so it was the manifest, that's good! Was it the tabs part?

RoarG Over a year ago

Same issue here. this show be on the front page of the google extension docs.

RocketDonkey · Accepted Answer · 2012-11-22 22:56:37Z

2

chrome.tabs.query actually returns an array of Tab objects, so you would have to reference the tab inside of the array (even if it is only one Tab):

$('#get-tab').click(function(){ chrome.tabs.query({"active" : true}, function(tab){ for (var i = 0; i < tab.length; i++) { alert(tab[i].url); $('#current-tab').append(tab[i].url); }; }); });

answered Nov 22, 2012 at 22:56

RocketDonkey

37.4k8 gold badges83 silver badges84 bronze badges

4 Comments

LICHEN Over a year ago

I initially did that (tab[i].url) as I knew that it returned an array, but that didn't seem to be working either, so I posted the script that I was trying instead, which didn't make much sense to me, but I was experimenting... See my edit above with my original code.

RocketDonkey Over a year ago

@Notionwork We'll go for the easy way first (hopefully :) ) - do you have tabs in your permissions in manifest.json?

LICHEN Over a year ago

Yup! Here's my manifest:

{	"name" : "Notionwork Site Manager",	"version" : "1.0",	"manifest_version" : 2,	"description" : "The manager organizes sites that are of interest and adds corrisponding bookmarks to the Chrome bookmark manager",	"browser_action" : {	"default_icon" : "icon.png",	"default_popup" : "popup.html"	},	"permissions" : [	"tabs"	],	"icons" : {	"128" : "icon.png"	} }

RocketDonkey Over a year ago

@Notionwork Alright, let's figure this thing out. Where are you defining your JavaScript? Is it directly inside of popup.html? One issue that comes up with manifest v2 is that you can no longer use in-line scripts, so if it is inside of there, try moving it into a popup.js as a background script that you call from popup.html.

Collectives™ on Stack Overflow

Tabs.url is undefined

2 Answers 2

2 Comments

4 Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

4 Comments

Related