How to assign different values to a string variable using in branches of if condition

Question

I have a problem with my script, here it is:

string myOutput = "image.png"; if (myOutput.Contains("youtu.be")) { string statementOutput = "Video ouput"; } else { if (myOutput.Contains(".png")) { string statementOutput = "Image output"; } else { string statementOutput = "Nothing's here"; } } Label1.Text = statementOutput;

With code above I get compile time error:

The name 'statementOutput' does not exist in the current context

What I wanna do is, if my string for example have "youtu.be" in the myOutput variable it makes the string "statementOutput" to the value "Video Ouput" and if it contains .png it changes the strings value to "Image Ouput" and if there is nothing in the "myOutput" string, it does nothing.

user2509901 · Accepted Answer · 2013-11-23 20:32:04Z

I think the problem is that you are declaring "statementOutput" in all the if-else statements. Try using

string myOutput = "image.png"; string statementOutput; if (myOutput.Contains("youtu.be")) { statementOutput = "Video output"; } else { if (myOutput.Contains(".png")) { statementOutput = "Image output"; } else { statementOutput = "Nothing's here"; } } Label1.Text = statementOutput;

Eduard Dumitru · Accepted Answer · 2013-11-23 20:48:10Z

1

Try this:

string myOutput = "image.png"; string statementOutput = "Nothing's here"; if (myOutput.Contains("youtu.be")) { statementOutput = "Video ouput"; } else if (myOutput.Contains(".png")) { statementOutput = "Image output"; } Label1.Text = statementOutput;

edited Nov 23, 2013 at 20:48

Eduard Dumitru

3,25019 silver badges32 bronze badges

answered Nov 23, 2013 at 20:34

Wilton

2262 silver badges14 bronze badges

2 Comments

Eduard Dumitru Over a year ago

That is also wrong. Whoever up voted is as much in a hurry as you were

Alexei Levenkov Over a year ago

+1. Default value probably should be String.Empty... With else if way of writing conditions it should be easier to chain any more conditions as needed.

Kobe-Wan Kenobi · Accepted Answer · 2013-11-23 20:56:09Z

This should work:

string myOutput = "image.png"; string statementOutput = ""; if (myOutput.Contains("youtu.be")) { statementOutput = "Video ouput"; } else { if (myOutput.Contains(".png")) { statementOutput = "Image output"; } else { statementOutput = "Nothing's here"; } } Label1.Text = statementOutput;

The problem is the scope of the variable. In case you're declaring your variable, you are declaring a variable that will exist only in current block of code, in which has been declared. In the way you wrote your code, in each of these code blocks different variable is declared, and at the end of each block, it is destroyed. You should clear yourself that even thought these variables have the same name, they are definitely not same.

Collectives™ on Stack Overflow

How to assign different values to a string variable using in branches of if condition

3 Answers 3

Comments

2 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Related